Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner March 9, 2025 20:20
@netlify
Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 7f5cdc0
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67cf896fcf26620008d67850
😎 Deploy Preview https://deploy-preview-1856--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.37%. Comparing base (e4e76d2) to head (925d1d3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...logd/controllers/core/clustercatalog_controller.go 0.00% 1 Missing ⚠️
...atalogd/controllers/core/pull_secret_controller.go 0.00% 1 Missing ⚠️
...r-controller/controllers/pull_secret_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1856      +/-   ##
==========================================
- Coverage   68.39%   68.37%   -0.03%     
==========================================
  Files          63       63              
  Lines        5136     5141       +5     
==========================================
+ Hits         3513     3515       +2     
- Misses       1392     1395       +3     
  Partials      231      231              
Flag Coverage Δ
e2e 51.61% <66.66%> (+0.08%) ⬆️
unit 55.96% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 force-pushed the test-performance branch 2 times, most recently from 75ed480 to 925d1d3 Compare March 10, 2025 10:05
@camilamacedo86 camilamacedo86 mentioned this pull request Mar 10, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant